From 4ffc29a6957cf962dff0211821505ad43f852582 Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Thu, 13 Apr 2017 18:59:39 -0700 Subject: [PATCH] Clarify getLaggedReplicaMode()/laggedReplicaUsed() in LoadBalancer Change-Id: I4ea9033d2d643c6758c49f34a69c9837598eea33 --- includes/libs/rdbms/loadbalancer/ILoadBalancer.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/includes/libs/rdbms/loadbalancer/ILoadBalancer.php b/includes/libs/rdbms/loadbalancer/ILoadBalancer.php index cbd0ff3401..dbf653dd98 100644 --- a/includes/libs/rdbms/loadbalancer/ILoadBalancer.php +++ b/includes/libs/rdbms/loadbalancer/ILoadBalancer.php @@ -444,13 +444,17 @@ interface ILoadBalancer { /** * @note This method will trigger a DB connection if not yet done * @param string|bool $domain Domain ID, or false for the current domain - * @return bool Whether the generic connection for reads is highly "lagged" + * @return bool Whether the database for generic connections this request is highly "lagged" */ public function getLaggedReplicaMode( $domain = false ); /** + * Checks whether the database for generic connections this request was both: + * - a) Already choosen due to a prior connection attempt + * - b) Considered highly "lagged" + * * @note This method will never cause a new DB connection - * @return bool Whether any generic connection used for reads was highly "lagged" + * @return bool */ public function laggedReplicaUsed(); -- 2.20.1